-
-
Notifications
You must be signed in to change notification settings - Fork 14
[WIP] Fix rendering issues on iOS #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It could be that the navigation modal you're using doesn't require FullWindowOverlay to render the magic modal on top of it. Have you tried rendering the modal on top without FullWindowOverlay? |
Here's my fix
and
|
@michael-pingo-ai It does require. Were you able to confirm that the fix in this PR was not enough and caused exit animation issues indeed? Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-04-26.at.15.42.31.mp4 |
I'll work on something similar this weekend. I'd love to use animation callbacks instead of using effect, or at least consider the configurable exit animation time (config.animationOutTiming) |
Yeah that sounds like a better fix. Here's what I'm seeing when I try just using modals.length which seems like it should be expected behavior. ScreenRecording_04-26-2025.13-46-40_1.MP4 |
Noted! I'd expect it indeed; unsure why it worked here. Thanks for hopping in and suggesting a fix I'll let you know once I get to it. I hope you're temporarily unblocked using your patch. |
Yes, we're unblocked with the patch. Thanks a lot for being so responsive! |
Description
packages/modal/src/components/MagicModalPortal/MagicModalPortal.tsx
: Introduced a new variable,shouldRenderFullWindowOverlay
, to include a condition that checks for the presence of modals before rendering theFullWindowOverlay
. This prevents unnecessary overlays when no modals are present.This fixes a reported issue where modals were having intermittent rendering issues on iOS.